. /** * Unit tests for core_grades\component_gradeitems; * * @package gradingform_rubric * @category test * @copyright 2019 Mathew May * @license http://www.gnu.org/copyleft/gpl.html GNU Public License */ declare(strict_types = 1); namespace gradingform_rubric\grades\grader\gradingpanel\external; use advanced_testcase; use coding_exception; use core_grades\component_gradeitem; use core_grades\component_gradeitems; use external_api; use mod_forum\local\entities\forum as forum_entity; use moodle_exception; /** * Unit tests for core_grades\component_gradeitems; * * @package gradingform_rubric * @category test * @copyright 2019 Mathew May * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later */ class fetch_test extends advanced_testcase { public static function setupBeforeClass(): void { global $CFG; require_once("{$CFG->libdir}/externallib.php"); } /** * Ensure that an execute with an invalid component is rejected. */ public function test_execute_invalid_component(): void { $this->resetAfterTest(); $user = $this->getDataGenerator()->create_user(); $this->setUser($user); $this->expectException(coding_exception::class); $this->expectExceptionMessage("The 'foo' item is not valid for the 'mod_invalid' component"); fetch::execute('mod_invalid', 1, 'foo', 2); } /** * Ensure that an execute with an invalid itemname on a valid component is rejected. */ public function test_execute_invalid_itemname(): void { $this->resetAfterTest(); $user = $this->getDataGenerator()->create_user(); $this->setUser($user); $this->expectException(coding_exception::class); $this->expectExceptionMessage("The 'foo' item is not valid for the 'mod_forum' component"); fetch::execute('mod_forum', 1, 'foo', 2); } /** * Ensure that an execute against a different grading method is rejected. */ public function test_execute_incorrect_type(): void { $this->resetAfterTest(); $forum = $this->get_forum_instance([ // Negative numbers mean a scale. 'grade_forum' => 5, ]); $course = $forum->get_course_record(); $teacher = $this->getDataGenerator()->create_and_enrol($course, 'teacher'); $student = $this->getDataGenerator()->create_and_enrol($course, 'student'); $this->setUser($teacher); $gradeitem = component_gradeitem::instance('mod_forum', $forum->get_context(), 'forum'); $this->expectException(moodle_exception::class); $this->expectExceptionMessage("not configured for advanced grading with a rubric"); fetch::execute('mod_forum', (int) $forum->get_context()->id, 'forum', (int) $student->id); } /** * Ensure that an execute against the correct grading method returns the current state of the user. */ public function test_execute_fetch_empty(): void { $this->resetAfterTest(); [ 'forum' => $forum, 'controller' => $controller, 'definition' => $definition, 'student' => $student, 'teacher' => $teacher, ] = $this->get_test_data(); $this->setUser($teacher); $gradeitem = component_gradeitem::instance('mod_forum', $forum->get_context(), 'forum'); $result = fetch::execute('mod_forum', (int) $forum->get_context()->id, 'forum', (int) $student->id); $result = external_api::clean_returnvalue(fetch::execute_returns(), $result); $this->assertIsArray($result); $this->assertArrayHasKey('templatename', $result); $this->assertEquals('gradingform_rubric/grades/grader/gradingpanel', $result['templatename']); $this->assertArrayHasKey('warnings', $result); $this->assertIsArray($result['warnings']); $this->assertEmpty($result['warnings']); // Test the grade array items. $this->assertArrayHasKey('grade', $result); $this->assertIsArray($result['grade']); $this->assertIsInt($result['grade']['timecreated']); $this->assertArrayHasKey('timemodified', $result['grade']); $this->assertIsInt($result['grade']['timemodified']); $this->assertArrayHasKey('usergrade', $result['grade']); $this->assertEquals(0, $result['grade']['usergrade']); $this->assertArrayHasKey('maxgrade', $result['grade']); $this->assertIsInt($result['grade']['maxgrade']); $this->assertEquals(100, $result['grade']['maxgrade']); $this->assertArrayHasKey('gradedby', $result['grade']); $this->assertEquals(null, $result['grade']['gradedby']); $this->assertArrayHasKey('criteria', $result['grade']); $criteria = $result['grade']['criteria']; $this->assertCount(count($definition->rubric_criteria), $criteria); foreach ($criteria as $criterion) { $this->assertArrayHasKey('id', $criterion); $criterionid = $criterion['id']; $sourcecriterion = $definition->rubric_criteria[$criterionid]; $this->assertArrayHasKey('description', $criterion); $this->assertEquals($sourcecriterion['description'], $criterion['description']); $this->assertArrayHasKey('levels', $criterion); $levels = $criterion['levels']; foreach ($levels as $level) { $levelid = $level['id']; if (!isset($levelid)) { continue; } $sourcelevel = $sourcecriterion['levels'][$levelid]; $this->assertArrayHasKey('criterionid', $level); $this->assertEquals($criterionid, $level['criterionid']); $this->assertArrayHasKey('checked', $level); $this->assertArrayHasKey('definition', $level); $this->assertEquals($sourcelevel['definition'], $level['definition']); $this->assertArrayHasKey('score', $level); $this->assertEquals($sourcelevel['score'], $level['score']); } } } /** * Ensure that an execute against the correct grading method returns the current state of the user. */ public function test_execute_fetch_graded(): void { $this->resetAfterTest(); $generator = \testing_util::get_data_generator(); $rubricgenerator = $generator->get_plugin_generator('gradingform_rubric'); [ 'forum' => $forum, 'controller' => $controller, 'definition' => $definition, 'student' => $student, 'teacher' => $teacher, ] = $this->get_test_data(); $this->setUser($teacher); $gradeitem = component_gradeitem::instance('mod_forum', $forum->get_context(), 'forum'); $grade = $gradeitem->get_grade_for_user($student, $teacher); $instance = $gradeitem->get_advanced_grading_instance($teacher, $grade); $submissiondata = $rubricgenerator->get_test_form_data($controller, (int) $student->id, 0, 'Too many mistakes. Please try again.', 2, 'Great number of pictures. Well done.' ); $gradeitem->store_grade_from_formdata($student, $teacher, (object) [ 'instanceid' => $instance->get_id(), 'advancedgrading' => $submissiondata, ]); $result = fetch::execute('mod_forum', (int) $forum->get_context()->id, 'forum', (int) $student->id); $result = external_api::clean_returnvalue(fetch::execute_returns(), $result); $this->assertIsArray($result); $this->assertArrayHasKey('templatename', $result); $this->assertEquals('gradingform_rubric/grades/grader/gradingpanel', $result['templatename']); $this->assertArrayHasKey('warnings', $result); $this->assertIsArray($result['warnings']); $this->assertEmpty($result['warnings']); // Test the grade array items. $this->assertArrayHasKey('grade', $result); $this->assertIsArray($result['grade']); $this->assertIsInt($result['grade']['timecreated']); $this->assertArrayHasKey('timemodified', $result['grade']); $this->assertIsInt($result['grade']['timemodified']); $this->assertArrayHasKey('usergrade', $result['grade']); $this->assertEquals(50, $result['grade']['usergrade']); $this->assertArrayHasKey('maxgrade', $result['grade']); $this->assertIsInt($result['grade']['maxgrade']); $this->assertEquals(100, $result['grade']['maxgrade']); $this->assertArrayHasKey('gradedby', $result['grade']); $this->assertEquals(fullname($teacher), $result['grade']['gradedby']); $this->assertArrayHasKey('criteria', $result['grade']); $criteria = $result['grade']['criteria']; $this->assertCount(count($definition->rubric_criteria), $criteria); foreach ($criteria as $criterion) { $this->assertArrayHasKey('id', $criterion); $criterionid = $criterion['id']; $sourcecriterion = $definition->rubric_criteria[$criterionid]; $this->assertArrayHasKey('description', $criterion); $this->assertEquals($sourcecriterion['description'], $criterion['description']); $this->assertArrayHasKey('remark', $criterion); $this->assertArrayHasKey('levels', $criterion); $levels = $criterion['levels']; foreach ($levels as $level) { $levelid = $level['id']; if (!isset($levelid)) { continue; } $sourcelevel = $sourcecriterion['levels'][$levelid]; $this->assertArrayHasKey('criterionid', $level); $this->assertEquals($criterionid, $level['criterionid']); $this->assertArrayHasKey('checked', $level); $this->assertArrayHasKey('definition', $level); $this->assertEquals($sourcelevel['definition'], $level['definition']); $this->assertArrayHasKey('score', $level); $this->assertEquals($sourcelevel['score'], $level['score']); } } $this->assertEquals(1, $criteria[0]['levels'][1]['checked']); $this->assertEquals('Too many mistakes. Please try again.', $criteria[0]['remark']); $this->assertEquals(1, $criteria[1]['levels'][3]['checked']); $this->assertEquals('Great number of pictures. Well done.', $criteria[1]['remark']); } /** * Get a forum instance. * * @param array $config * @return forum_entity */ protected function get_forum_instance(array $config = []): forum_entity { $this->resetAfterTest(); $datagenerator = $this->getDataGenerator(); $course = $datagenerator->create_course(); $forum = $datagenerator->create_module('forum', array_merge($config, ['course' => $course->id, 'grade_forum' => 100])); $vaultfactory = \mod_forum\local\container::get_vault_factory(); $vault = $vaultfactory->get_forum_vault(); return $vault->get_from_id((int) $forum->id); } /** * Get test data for forums graded using a rubric. * * @return array */ protected function get_test_data(): array { global $DB; $this->resetAfterTest(); $generator = \testing_util::get_data_generator(); $rubricgenerator = $generator->get_plugin_generator('gradingform_rubric'); $forum = $this->get_forum_instance(); $course = $forum->get_course_record(); $teacher = $this->getDataGenerator()->create_and_enrol($course, 'teacher'); $student = $this->getDataGenerator()->create_and_enrol($course, 'student'); $this->setUser($teacher); $controller = $rubricgenerator->get_test_rubric($forum->get_context(), 'forum', 'forum'); $definition = $controller->get_definition(); // In the situation of mod_forum this would be the id from forum_grades. $itemid = 1; $instance = $controller->create_instance($student->id, $itemid); $data = $this->get_test_form_data( $controller, $itemid, 1, 'This user made several mistakes.', 0, 'Please add more pictures.' ); // Update this instance with data. $instance->update($data); return [ 'forum' => $forum, 'controller' => $controller, 'definition' => $definition, 'student' => $student, 'teacher' => $teacher, ]; } /** * Fetch a set of sample data. * * @param \gradingform_rubric_controller $controller * @param int $itemid * @param float $spellingscore * @param string $spellingremark * @param float $picturescore * @param string $pictureremark * @return array */ protected function get_test_form_data( \gradingform_rubric_controller $controller, int $itemid, float $spellingscore, string $spellingremark, float $picturescore, string $pictureremark ): array { $generator = \testing_util::get_data_generator(); $rubricgenerator = $generator->get_plugin_generator('gradingform_rubric'); return $rubricgenerator->get_test_form_data( $controller, $itemid, $spellingscore, $spellingremark, $picturescore, $pictureremark ); } }